JPT_TrackJets seed reco and PAT rereco 11_2_x based #30188

kodolova · 2020-06-11T08:54:58Z

PR description:

Improved efficiency for low Pt jets via TrackJets seeding. Possibility to rereconstructed with MiniAOD objects.

PR description:

Presented at Reconstruction meeting
https://indico.cern.ch/event/923095/

PR validation:

Tests are performed according:https://cms-sw.github.io/PRWorkflow.html
Result of runTheMatrix test is in:
/afs/cern.ch/work/k/kodolova/public/HMUMUBB/CMSSW_11_2_X_2020-06-10-2300/src/TEST

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

…pty() clean Buildfile.xml

…15988/code-format.patch e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30160/15988/code-format.patch | patch -p1 You can also run scram build code-format Provide some additional clean-up: introduce variable dRcone instead of 0.4

cmsbuild · 2020-06-11T08:55:24Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-11T09:04:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30188/16023

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoJets/JetPlusTracks/plugins/BuildFile.xml modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackAddonSeedProducer.cc modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackAddonSeedProducer.h modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.cc modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.h modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.orig modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.rej modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.orig modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.rej modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.cc modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.h modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/python/JetPlusTrackCorrectionsAA_cff.py modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/python/JetPlusTrackCorrections_cff.py modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/python/JetPlusTrackCorrections_cfi.py modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160
- File RecoJets/JetPlusTracks/python/PATJetPlusTrackCorrections_cff.py modified in PR(s): JPT_TrackJetsSeeds_Reco_and_PATrereco #30160

cmsbuild · 2020-06-11T09:04:35Z

A new Pull Request was created by @kodolova (kodolova) for master.

It involves the following packages:

RecoJets/JetPlusTracks

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-06-11T09:07:49Z

please test

cmsbuild · 2020-06-11T09:08:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6951/console Started: 2020/06/11 11:12

cmsbuild · 2020-06-11T10:03:12Z

-1

Tested at: 3e4f489

CMSSW: CMSSW_11_2_X_2020-06-10-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-baf827/6951/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.793 step3

runTheMatrix-results/136.793_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step3_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log

136.874 step3

runTheMatrix-results/136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

23234.1001 step1

runTheMatrix-results/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

11634.0 step3

runTheMatrix-results/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

12434.0 step3

runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Thu Jun 11 11:51:59 2020-date Thu Jun 11 11:51:05 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:53:18 2020-date Thu Jun 11 11:51:07 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:56:10 2020-date Thu Jun 11 11:51:09 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:2018,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2018 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018_MC.root --fileout file:RelVal_Raw_2018_MC_HLT_RECO.root : FAILED - time: date Thu Jun 11 12:01:17 2020-date Thu Jun 11 11:51:13 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Jun 11 12:00:53 2020-date Thu Jun 11 11:51:16 2020 s - exit: 18688
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Thu Jun 11 11:52:19 2020-date Thu Jun 11 11:51:21 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:2018,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018_DATA.root --fileout file:RelVal_Raw_2018_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:59:40 2020-date Thu Jun 11 11:51:23 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:56:52 2020-date Thu Jun 11 11:51:26 2020 s - exit: 18688
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Thu Jun 11 11:52:31 2020-date Thu Jun 11 11:51:29 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:55:42 2020-date Thu Jun 11 11:51:31 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:56:33 2020-date Thu Jun 11 11:51:35 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:57:03 2020-date Thu Jun 11 11:51:44 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:56:14 2020-date Thu Jun 11 11:51:49 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:55:37 2020-date Thu Jun 11 11:52:07 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 11 12:00:47 2020-date Thu Jun 11 11:52:09 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:56:03 2020-date Thu Jun 11 11:52:23 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Jun 11 11:57:57 2020-date Thu Jun 11 11:52:34 2020 s - exit: 18688

cmsbuild · 2020-06-11T10:03:14Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-06-16T09:40:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-16T09:47:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30188/16167

This PR adds an extra 108KB to repository
Found files with invalid states:
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.rej:
  - Added: 3e4f489
  - Deleted: fa5a5cb
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.rej:
  - Added: 3e4f489
  - Deleted: fa5a5cb
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.orig:
  - Added: 3e4f489
  - Deleted: fa5a5cb
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.orig:
  - Added: 3e4f489
  - Deleted: fa5a5cb
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducerAA.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-16T09:47:34Z

Pull request #30188 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2020-06-18T13:02:26Z

@cmsbuild please test

cmsbuild · 2020-06-18T13:02:50Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-17-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7177/console Started: 2020/06/18 15:29

cmsbuild · 2020-06-18T14:39:54Z

+1
Tested at: 84a0c65
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-baf827/7177/summary.html
CMSSW: CMSSW_11_2_X_2020-06-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-18T14:39:57Z

Comparison job queued.

cmsbuild · 2020-06-18T16:27:06Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-baf827/7177/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778760
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

slava77

Please add an example test where the "PAT" variant is used.

It's likely there will be another smaller round after this one.

slava77 · 2020-06-19T15:49:01Z

RecoJets/JetPlusTracks/plugins/BuildFile.xml

@@ -1,16 +1,25 @@
 <export>
 </export>
-<library file="*.cc" name="RecoJetsJetPlusTracks_plugins">


please restore this file formatting as it was in 11_2_X before this PR.

slava77 · 2020-06-19T21:33:20Z

RecoJets/JetPlusTracks/plugins/BuildFile.xml

+  <use   name="DataFormats/DetId"/>
+  <use   name="DataFormats/EgammaReco"/>
+  <use   name="DataFormats/EgammaCandidates"/>
+  <use   name="EgammaAnalysis/ElectronTools"/>


Suggested change

<use name="EgammaAnalysis/ElectronTools"/>

not used in this PR => should not be needed

slava77 · 2020-06-19T21:34:20Z

RecoJets/JetPlusTracks/plugins/BuildFile.xml

+  <use   name="DataFormats/JetReco"/>
+  <use   name="DataFormats/Math"/>
+  <use   name="DataFormats/MuonReco"/>
+  <use   name="DataFormats/Provenance"/>


Suggested change

<use name="DataFormats/Provenance"/>

newly added, but apparently not used in this PR => can drop

slava77 · 2020-06-19T21:35:17Z

RecoJets/JetPlusTracks/plugins/BuildFile.xml

+  <use   name="FWCore/ParameterSet"/>
+  <use   name="Geometry/Records"/>
+  <use   name="Geometry/TrackerGeometryBuilder"/>
+  <use   name="RecoEgamma/EgammaTools"/>


Suggested change

<use name="RecoEgamma/EgammaTools"/>

newly added, but apparently not used in this PR => can drop

slava77 · 2020-06-19T21:36:51Z

RecoJets/JetPlusTracks/plugins/JetPlusTrackAddonSeedProducer.cc

+// Class:      JetPlusTrackProducer
+//
+/**\class JetPlusTrackProducer JetPlusTrackProducer.cc JetPlusTrackProducer.cc


this does not match the actual class name; please update

slava77 · 2020-06-20T02:11:03Z

RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc

+        for (std::vector<edm::Ptr<reco::Track> >::iterator itrack = tracksinjet.begin(); itrack != tracksinjet.end();
+             itrack++) {
+          for (std::vector<reco::TrackExtrapolation>::const_iterator xtrpBegin = iExtrapolations->begin(),
+                                                                     xtrpEnd = iExtrapolations->end(),
+                                                                     ixtrp = xtrpBegin;
+               ixtrp != xtrpEnd;
+               ++ixtrp) {
+            if (ixtrp->positions().empty())
+              continue;
+            double mydphi = deltaPhi(ixtrp->track()->phi(), (**itrack).phi());
+            if (fabs(ixtrp->track()->pt() - (**itrack).pt()) > 0.001 ||
+                fabs(ixtrp->track()->eta() - (**itrack).eta()) > 0.001 || mydphi > 0.001)
+              continue;


this deep-nested cross-referencing via eta,phi will likely have to be redone (pending timing cost review)

slava77 · 2020-06-20T02:15:01Z

RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.cc

+  pat::ElectronCollection::const_iterator ielec = elecs->begin();
+  pat::ElectronCollection::const_iterator jelec = elecs->end();
+  for (; ielec != jelec; ++ielec) {


Suggested change

pat::ElectronCollection::const_iterator ielec = elecs->begin();

pat::ElectronCollection::const_iterator jelec = elecs->end();

for (; ielec != jelec; ++ielec) {

for (auto const& elec : *elscs) {

slava77 · 2020-06-20T02:15:46Z

RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.cc

+  if (deltaRMIN < electronDRmatch_) { /*std::cout<<"Electron is accepted "<<std::endl;*/
+    return true;
+  } else
+    return false;


Suggested change

if (deltaRMIN < electronDRmatch_) { /*std::cout<<"Electron is accepted "<<std::endl;*/

return true;

} else

return false;

return deltaRMIN < electronDRmatch_;

slava77 · 2020-06-20T02:16:12Z

RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.cc

+  if (deltaRMIN < electronDRmatch_)
    return true;
  else
    return false;


Suggested change

if (deltaRMIN < electronDRmatch_)

return true;

else

return false;

return deltaRMIN < electronDRmatch_;

slava77 · 2020-06-20T02:17:14Z

RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.cc

-    if (deltaR < deltaRMIN) {
-      deltaRMIN = deltaR;
+
+    dR = deltaR(ielec->eta(), ielec->phi(), (*itrk)->momentum().eta(), (*itrk)->momentum().phi());


Suggested change

dR = deltaR(ielec->eta(), ielec->phi(), (*itrk)->momentum().eta(), (*itrk)->momentum().phi());

dR = deltaR(*ielec, **itrk);

kodolova · 2020-06-23T14:49:24Z

Hi Slava, in e-mail that I got I have much more changes that I need to do. I am trying to fullfil the request. But some items I do not understand. In particular, RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.cc... You propose to move it to another package? But I have not commit rights, I think to another package? Should I do it or this is for future?

slava77 · 2020-06-23T15:20:16Z

Hi Slava, in e-mail that I got I have much more changes that I need to do. I am trying to fullfil the request.

Thank you. I hope we converge soon.

But some items I do not understand. In particular, RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.cc... You propose to move it to another package? But I have not commit rights, I think to another package? Should I do it or this is for future?

The concept of "commit right" is from CVS and does not apply with git. PRs in git can include changes in any parts of CMSSW.

kodolova · 2020-06-26T15:19:50Z

The new PR 30430 is opened.

kodolova added 8 commits June 11, 2020 10:41

TrackJet seeds adding

d26f82d

TrackJet seeds adding

64ff2b8

TrackJet seeds adding

f7ff65e

TrackJet seeds adding

d8df825

TrackJet seeding

620d7e7

Cleaned Buildfile.xml from duplication

1caafe3

Make cleaning, i.e. change comaprison of collection size with 0 to em…

3ebe833

…pty() clean Buildfile.xml

cmsbuild added this to the CMSSW_11_2_X milestone Jun 11, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 11, 2020

kodolova changed the title ~~Jpt track jets seed reco pa trereco 11 2 xbased~~ JPT_TrackJets seed reco and PAT rereco 11_2_x based Jun 11, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 11, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 11, 2020

cmsbuild added comparison-notrun and removed comparison-pending tests-started labels Jun 11, 2020

kodolova added 2 commits June 16, 2020 10:59

Chnage to deltaR and deltaPhi

a0b5fa6

Code-formatting after changes

84a0c65

cmsbuild added code-checks-pending comparison-pending tests-pending and removed code-checks-approved comparison-available tests-approved labels Jun 16, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 16, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 18, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 18, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 18, 2020

slava77 reviewed Jun 20, 2020

View reviewed changes

kodolova closed this Jun 26, 2020

slava77 mentioned this pull request Jun 26, 2020

Trackjets as seeds of JetPlusTrack at RECO and MINIAOD #30430

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JPT_TrackJets seed reco and PAT rereco 11_2_x based #30188

JPT_TrackJets seed reco and PAT rereco 11_2_x based #30188

kodolova commented Jun 11, 2020 •

edited

Loading

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

perrotta commented Jun 11, 2020

cmsbuild commented Jun 11, 2020 •

edited

Loading

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

slava77 commented Jun 18, 2020

cmsbuild commented Jun 18, 2020 •

edited

Loading

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

slava77 left a comment

slava77 Jun 19, 2020

slava77 Jun 19, 2020

slava77 Jun 19, 2020

slava77 Jun 19, 2020

slava77 Jun 19, 2020

slava77 Jun 20, 2020

slava77 Jun 20, 2020

slava77 Jun 20, 2020

slava77 Jun 20, 2020

slava77 Jun 20, 2020

kodolova commented Jun 23, 2020

slava77 commented Jun 23, 2020

kodolova commented Jun 26, 2020

	dR = deltaR(ielec->eta(), ielec->phi(), (itrk)->momentum().eta(), (itrk)->momentum().phi());
	dR = deltaR(ielec, *itrk);

JPT_TrackJets seed reco and PAT rereco 11_2_x based #30188

JPT_TrackJets seed reco and PAT rereco 11_2_x based #30188

Conversation

kodolova commented Jun 11, 2020 • edited Loading

PR description:

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

perrotta commented Jun 11, 2020

cmsbuild commented Jun 11, 2020 • edited Loading

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 11, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

slava77 commented Jun 18, 2020

cmsbuild commented Jun 18, 2020 • edited Loading

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

slava77 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kodolova commented Jun 23, 2020

slava77 commented Jun 23, 2020

kodolova commented Jun 26, 2020

kodolova commented Jun 11, 2020 •

edited

Loading

cmsbuild commented Jun 11, 2020 •

edited

Loading

cmsbuild commented Jun 18, 2020 •

edited

Loading